Frederik Creemers

posts

Lay Out Your Code Like You'd Lay Out Your House


Imagine you wake up and get up to brush your teeth. You go to the “brooms and brushes” room to get your toothbrush. Then, you go to the “cleaning products” room to get toothpaste. You continue to the “containers” room to get a cup, and finally, you head into the “inputs and outputs” room, where you have a tap that lets water enter your house, and a sink with a drain through which fluids can leave your house. You now have everything to go brush your teeth.

I won’t bore you by describing the rest of your day in this very strange house in detail, but you can imagine getting a knife to spread some peanut butter on your bread from the “cutters” room, where you also keep your razors and garden shears. It’d obviously be incredibly inconvenient of your house were laid out that way. And yet, we often structure our code bases this way.

Why Is This So Inconvenient?

In the example above, you had to visit 4 different rooms just to brush your teeth. This is ridiculous! You’d expect everything you need to brush your teeth to be conveniently located together.

So let’s have a look at an example code base for a hypothetical blogging application. Since it’s a hypothetical code base, I’m not using any specific web/database/… framework here. The code will be written in Python, but you don’t need to know Python to get the point of this post.

The structure of the app might look like this:

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
BogoBlog/
├── main.py
├── controllers/
│   ├── posts.py
│   ├── comments.py
│   └── users.py
├── errors/
│   ├── posts.py
│   ├── comments.py
│   └── users.py
├── storage/
│   ├── posts.py
│   ├── comments.py
│   └── users.py
├── templates/
│   ├── posts/
│   │   ├── post.html
│   │   └── ... more files ...
│   ├── comments/ ...more files inside ...
│   └── users/ ...more files inside ...
└── validators/
    ├── posts.py
    ├── comments.py
    └── users.py

This looks like an MVC application. Let’s take a look at the controllers/posts.py file:

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
from cool_web_framework import BaseController, HttpForbiddenError, HttpNotFoundError,
from storage.posts import PostsStore
from storage.users import UsersStore
from errors.posts import PostNotFoundError
from errors.users import UserNotFoundError
from validators.posts import validate_post

class PostController(BaseController):
    def get(self, postId):
        """Handle GET requests to /posts/{postId}"""
            post = self.fetch_post(postId)
        
        if post.is_draft:
            self.ensure_current_user_can_edit(post)
        
        return self.render_template("templates/post.html", post)
    
    def post(self, postId):
        """Handle POST requests to /posts/{postId}"""
        post = self.fetch_post(postId)
        
        self.ensure_current_user_can_edit(post)
        
        data = self.request.body.json()
        err = validate_post(data)
        if err:
            raise HttpBadRequestError(err)
        
        post.update(data)
        PostsStore.save(post)
        return self.redirect("/")
    
    def fetch_post(self, postId):
        try: 
            return PostsStore.get_post_by_id(postId)
        except PostNotFoundError:
            raise HttpNotFoundError("No post with id " + postId)
    
    def ensure_current_user_can_edit(self):
        err = HttpForbiddenError("You don't have permission to view this post.")
        try:
            return UsersStore.get_current_user(self.request)
        except UserNotFoundError:
            raise err
        
        if not (user.is_admin or post.author == user):
            raise err

This code might look reasonable, but there’s a problem when things change. For example, the file above imports functions from manny other modules. If any of these modules changes their public interface, this file needs to be updated. But since the file is not located near the change, you need to search through the entire code base to see where the changed function is called in order to update the calls. For a more concrete example, imagine you are asked to add a “banner_image” field to posts to make them more visually interesting. This required changes in:

While this isn’t too bad in a code base of this size, as your code base grows, it becomes harder to track down where things need to be changed. Having to jump around this much also makes the code base harder to understan. The reason we’re editing files all over the place to add a feature is because we’ve grouped files by what type of code they hold in terms of te MVC pattern, rather than grouping them by what functionality they provide.

Let’s Fix This!

Let’s group all posts-related functionality together, all users-related functionality together, etc…

 1
 2
 3
 4
 5
 6
 7
 8
 9
10
11
12
13
14
15
16
17
BogoBlog/
├── main.py
├── posts/
│   ├── controllers.py
│   ├── storage.py
│   ├── validators.py
│   └── templates/
│       ├── post.html
│       └── ... more files ...
├── comments/
│   ├── controllers.py
│   ├── storage.py
│   └── validators.py
└── users/
    ├── controllers.py
    ├── storage.py
    └── validators.py

So now, when we need to change something related to posts, you’ll likely just have to edit files in /posts, and the same goes for other pieces of functionality. Of course, you may still need to edit code in multiple directories, but at least now you’re thinking in terms of which features of the app a change affects.

Cohesion

When talking about what belongs together in a software project, the word Cohesion is often used. As we all know, Wikipedia is the source of all truth on the internet, so let’s see what Wikipedia has to say about cohesion.

In computer programming, cohesion refers to the degree to which the elements inside a module belong together.[1] In one sense, it is a measure of the strength of relationship between the methods and data of a class and some unifying purpose or concept served by that class. In another sense, it is a measure of the strength of relationship between the class’s methods and data themselves.

Ok, so cohesion just means “how much parts of a program belong together”. The definition of the term doesn’t say anything about how it should be measured, but it is often used without further defining it. People just say you should have “high cohesion”.

Later in the same article, there’s a list of different types of cohesion, defined by how they are measured.

  • Functional cohesion is when parts of a module are grouped because they all contribute to a single well-defined task of the module (e.g. Lexical analysis of an XML string).

[…]

Studies by various people including Larry Constantine, Edward Yourdon, and Steve McConnell [3] indicate that […] and functional cohesion is superior.

Functional cohesion sounds a lot like what we just did, right? Grouping things by what functionality they contribute to. So when talking about cohesion, please be specific about what type of cohesion you mean.

I removed a lot of content from this citation because I didn’t feel like citing a whole section from Wikipedia and then re-explaining it. I might spend some more time looking into this, and writing another article about cohesion, because I think this Wikipedia article puts too much emphasis on object-oriented programming, and I’d love to take a look at what cohesion means at diferent levels of granularity and in different programming paradigms.

Other Considerations.

Thanks for reading!

Please let me know what you think on Twitter